search

AlexandrePTJ / mopidy-somafm

Provides a backend for playing music from somafm
MIT License
22 stars 9 forks source link

Channel fallback pls #29

Closed tardypad closed 7 years ago

tardypad commented 7 years ago

This fixes #24

It is not really a full "graceful degradation" but it introduces a fallback mechanism so that no SomaFM channel gets lost. All of them stay available.

A real "graceful degradation" implementation would be more complex in terms of code while this is relatively simple. It is a similar fallback as I used in one my app https://github.com/tardypad/sailfishos-somafm/blob/master/src/Player.cpp#L187

The config doesn't change at all

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 60.87% when pulling 681ea1673f519169b39e059f2fdab4e500c1e2b0 on tardypad:channel_fallback_pls into d5cb6268b2a691c28f7b8845fd0e76b99fad4452 on AlexandrePTJ:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 60.87% when pulling e63d034f1760cea1d43d0e8cd844df582eedd974 on tardypad:channel_fallback_pls into d5cb6268b2a691c28f7b8845fd0e76b99fad4452 on AlexandrePTJ:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 60.87% when pulling a8615551fd9126f59a10731510431655c4efc0f0 on tardypad:channel_fallback_pls into d5cb6268b2a691c28f7b8845fd0e76b99fad4452 on AlexandrePTJ:develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 60.87% when pulling 333945ddf51237a2dee6fe0f9c778477f772b59d on tardypad:channel_fallback_pls into d5cb6268b2a691c28f7b8845fd0e76b99fad4452 on AlexandrePTJ:develop.

AlexandrePTJ commented 7 years ago

@tardypad Thanks you for this PR.