AlexandreRouma / SDRPlusPlus

Cross-Platform SDR Software
GNU General Public License v3.0
3.88k stars 533 forks source link

baseband filename template #1253

Open rs1729 opened 8 months ago

rs1729 commented 8 months ago

Recording baseband, filename template $r would put "Unknown" in the filename: https://github.com/AlexandreRouma/SDRPlusPlus/blob/794d6ff5acf66d5da7fb7fceba7b952c95305960/misc_modules/recorder/src/main.cpp#L470 Can baseband be something else than IQ data? If not, perhaps "IQ" would be the better choice

        const char* modeStr = "IQ";

cf. https://github.com/AlexandreRouma/SDRPlusPlus/pull/1166#issuecomment-1708037722

AlexandreRouma commented 8 months ago

The point of naming it "unknown" is because the r template represents the modulation of the recorded signal, and since it's recording baseband, that modulation is 'unknown'. Having "IQ" in the name would be redundant with the "baseband" recording type

rs1729 commented 8 months ago

Yes, using $t_$y$M$d_$h$m$s_$f_$rit would be redundant. Using $rI wouldn't need $t anymore. When I choose "audio" it puts the (de)modulation in the filename. For baseband it puts "unknown". And if the "unknown" string would be set to an empty string for baseband, the filename would be something like "baseband_20231216_060000400000000Hz.wav", still including the "" at the end. With `$y$M$d$h$m$s$f$r`a filename like "20231216_060000_400000000Hz_IQ.wav" would tell me, it is baseband. No modulation, just IQ data. The "audio" recordings with chosen demodulation would have different names.