search

AlexandreRouma / SDRPlusPlus

Cross-Platform SDR Software
GNU General Public License v3.0
3.76k stars 516 forks source link

Add heartbeat to SDR++ Server protocol #1358

Open lutusp opened 3 months ago

lutusp commented 3 months ago

This may be taken as a feature request rather than a bug report (it's both), but if a client disconnects from an SDR++ server without first closing the network connection, the server doesn't know it's been orphaned and refuses new connections, then any new clients crash.

One remedy would be to automatically close any active network connection when the user closes the client app (this would free the server). Another would be to prevent the client crash, instead print the connection failure reason on stdout and carry on without crashing. The first remedy is better overall.

Another remedy would be for the client/server connection to use a heartbeat signal to detect active connections, but this is more difficult to implement.

Also ... it's a terrific program. I know, I've written a few myself and this one is much better.

AlexandreRouma commented 2 months ago

Yeah I'll switch this a to a feature request as the server protocol doesn't have a heartbeat system. This will be taken care of in version 2.0 of the protocol.