AlexandreRouma / SDRPlusPlus

Cross-Platform SDR Software
GNU General Public License v3.0
4.16k stars 576 forks source link

Fobos not included in Mac build #1485

Closed thereisnocat closed 1 month ago

thereisnocat commented 1 month ago

WARNING: Filling out the template below is NOT optional. Issues not filling out this template will be closed without review.

FIRST: Before reporting any bug, make sure that the bug you are reporting has not been reported before. Also, try to use the nightly version if possible in case I've already fixed the bug.

Hardware

Software

Bug Description A clear description of the bug.

The Mac build does not include the library for the FobosSDR due to a typo.

Steps To Reproduce

  1. Download and open the macOS nightly build
  2. Open the list of receivers under Source
  3. Note that FobosSDR is not included.

Only If SDR++ fails to lauch or the SDR fails to start: Run SDR++ from a command line window with special parameters:

Screenshots Add any screenshot that is relevant to the bug (GUI error messages, strange behavior, graphics glitch, etc…).

Additional info Add any other relevant information.

I was able to pull the source from Github and build locally and saw the same thing. The issue is in make_macos_bundle.sh. Line 38 points to fobossdr_source.dylib in the wrong directory (file_source instead of fobossdr_source). The dylib is created, but it is not incorporated into the application. By updating the directory, I was able to build the application with support for FobosSDR.

AlexandreRouma commented 1 month ago

Should be fixed, I'll reopen if not.