Regression in clock module formatting

[exit91]

Regression from Version 0.9.24 to version 0.10.3:

The clock module shows an empty string, instead of the time according to the custom formatting.

    "clock": {
        "format": "{:󰃭 %a %d %b 󰅐 %H:%M}"
    },

Removing the unicode characters 󰃭 and 󰅐 preceding %a and %H makes the rendering work again.

Error log:

[2024-06-10 09:21:26.734] [error] clock: chrono format error: no '%' at start of chrono-specs
[2024-06-10 09:21:26.838] [error] clock: chrono format error: no '%' at start of chrono-specs

[khaneliman]

Hmm.. assuming it has to do with the chrono API change. https://github.com/Alexays/Waybar/commit/86a38980e4a2eb242379b9221b06784d3e0d3eef But, I'm curious if you git-bisect if that's true..

[exit91]

I tried bisecting between releases 0.10.0 and 0.10.1 using nix build to build the program. Sometimes it wouldn't build due to a missing dependency

> meson.build:95:17: ERROR: Dependency "wireplumber-0.5" not found, tried pkgconfig

In those cases I removed wireplumber from meson.build before calling nix build.

Result of performing bisect:

5056309963dec9e944da6b11a593e94bbe02db5f is the first bad commit
commit 5056309963dec9e944da6b11a593e94bbe02db5f
Author: Lin Xianyi <iynaix@gmail.com>
Date:   Mon Mar 25 22:47:37 2024 +0800

    nix: build against wireplumber 0.5

 flake.lock      | 6 +++---
 nix/default.nix | 6 +++++-
 2 files changed, 8 insertions(+), 4 deletions(-)

It looks like the bug is caused by the updated flake.lock, which means that the problem may not lie with waybar, but some dependency.

[exit91]

I tried to build 0.10.0 (which did not have the regression) again, but with the flake.lock from commit 5056309963dec9e944da6b11a593e94bbe02db5f, and this build does exhibit the bug.

[exit91]

Seems to be a duplicate of these, which are closed, probably due to the existence of a workaround.

https://github.com/Alexays/Waybar/issues/3058 https://github.com/Alexays/Waybar/issues/3021

Feel free to close this issue as well.