modules/hyprland/backend: handle empty socket response - Githubissues

Alexays / Waybar

Highly customizable Wayland bar for Sway and Wlroots based compositors. :v: :tada:

MIT License

6.4k stars 696 forks source link

modules/hyprland/backend: handle empty socket response #3389

Closed khaneliman closed 3 months ago

khaneliman commented 3 months ago

Issues:

Resolves https://github.com/Alexays/Waybar/issues/3388
Resolves https://github.com/Alexays/Waybar/issues/3365

This PR:

We will check for an empty response from getSocketReply before trying to parse JSON. Before the empty response check we get the JSON parse error from the JSON module. After the change, we wont try and parse the message that will cause the crash.
Also includes some clangd cleanup.
Added test to verify we dont crash when we receive an empty socket response.

Alexays commented 3 months ago

Thanks!