Alexays / Waybar

Highly customizable Wayland bar for Sway and Wlroots based compositors. :v: :tada:
MIT License
6.78k stars 710 forks source link

hyprland/workspaces window title url icon rewrite #3705

Open j5onrf opened 1 month ago

j5onrf commented 1 month ago

Will it ever be possible to control workspace icon rewrite by url?

Example: What is the solution to get the github icon to show in workspace rewrite when visiting github.com?

The title of github.com pages do not include the word "github". "title<.github.>": "",

My weak solution "title<.dot.>": "",

JanValiska commented 1 month ago

This is what is available from wayland window properties for this issue github page:

❯ hyprprop
{
  "address": "0x5877e11f8980",
  "mapped": true,
  "hidden": false,
  "at": [
    15,
    56
  ],
  "size": [
    1255,
    1369
  ],
  "workspace": {
    "id": 2,
    "name": "2"
  },
  "floating": false,
  "pseudo": false,
  "monitor": 0,
  "class": "firefox",
  "title": "hyprland/workspaces window title url icon rewrite · Issue #3705 · Alexays/Waybar — Mozilla Firefox",
  "initialClass": "firefox",
  "initialTitle": "Mozilla Firefox",
  "pid": 1703,
  "xwayland": false,
  "pinned": false,
  "fullscreen": 0,
  "fullscreenClient": 0,
  "grouped": [],
  "tags": [],
  "swallowing": "0x0",
  "focusHistoryID": 1
}

As you said and as you can clearly see, there is no github mention in the output. So there is no direct way to check if browser window is github page.

I doubt that someone will implement some "mega superb github page title matching algorithm 3000" specifically for github. And even if someone will, the question is if such a non-generic feature should be part of generic waybar. :)

j5onrf commented 1 month ago

What about "url<.github.>": "", instead of "title<.github.>": "",

This is universal. I'm asking if this is simple to implement.