Hyprland - Window module doesn't change to fullscreen style if a stacked window group is on fullscreen

Alexays / Waybar

Highly customizable Wayland bar for Sway and Wlroots based compositors. :v: :tada:

MIT License

6.75k stars 708 forks source link

Hyprland - Window module doesn't change to fullscreen style if a stacked window group is on fullscreen #3746

Closed izmyname closed 1 week ago

izmyname commented 2 weeks ago

I have a window#waybar.fullscreen #window in my style.css configured in the way it changes colours, whenever a focused window is on fullscreen. However, it doesn't change its style if I put a stacked window group on fullscreen.

To demonstrate.

default window style, no fullscreen.
firefox window is on fullscreen - the module changed its colours.
firefox is inside a stacked group, the group is on fullscreen - the module didn't change its colours.

izmyname commented 2 weeks ago

Some more info from Hyprland discussions. https://github.com/hyprwm/Hyprland/discussions/8369#discussioncomment-11165849

Aqa-Ib commented 2 weeks ago

Having a quick look at waybar's code, it seems that the issue is here: https://github.com/Alexays/Waybar/blob/5f260516af9a3e5791c26c7fc18a85a47da5b23f/src/modules/hyprland/window.cpp#L194-L198

I would argue that both flags are wrong, because:

the active group member can be fullscreened.
technically, a grouped window can be solo as well, because only the active group member is shown, the other members are hidden. Also you can have a group consisting of only one window.

Seems to me that this block could be entirely removed.

izmyname commented 2 weeks ago

Removing the code above, before building, fixes the problem.