Code review 1

[tshemsedinov]

• Add 'use strict';
• axios -> undici
• Use arrow functions instead of function (message) {
• const config = require('./config.js');

module.exports = {
  port: process.env.PORT || 80,
  api: {
    key: 'c33616c4ada296c918a35b2d9dbc7fb3',
    url: 'https://api.themoviedb.org/3/discover/movie',
  }
  // other paramaters...
};

• Use collections instead of if-statements

const commands = {
  CLIENTDATA: (ws, msg) => {},
  NEWRATING: (ws, msg) => {},
};

• Prefer const in this case let films = {};
• Decompose long functions
  • For example: extract 3rd party server request into separate module
  • See lectures:
  • https://youtu.be/CJr2vS3hjMU
  • https://youtu.be/31sX_3IbXs4
• Do not use == (use ===) because it can lead to type casting and we have common code-style to avoid == at all
• Use constants instead of magic numbers:

  const COMEDY = 35;
  { // or even implement function getGenreEndpoint(number): string
  const { url, key } = config.api;
  const endpoint = `${url}?api_key=${key}&with_genres=${COMEDY}`;
  }

• Decompose long expressions:

  
  const add = (a, b) => a + b;
  const avg = (arr) => arr.reduce(add, 0) / arr.length;

const record = ratings[film.id]; const result = record ? avg(record) : "No rating";

- Remove code duplicate code

[Alexe1900]

Done!