Incorrect Skill Improvement Logic

[glory61]

The current calculation of best skill is incorrect as it uses the total profit per hour after the upgrade instead of the incremental profit gained from the upgrade.

Example:

Upgrade Computers Profit per hour: 120,000 Incremental profit per hour: 10,000 Price: 1,000,000

Current logic: 1,000,000 / 130,000 = profit in 7.69 hours

Correct logic: 1,000,000 / 10,000 = profit in 100 hours

I've fixed this issue for myself, but you should consider addressing it in upcoming commits.

[Alexell]

Please provide more information with variable names

[glory61]

Please provide more information with variable names

The current implementation calculates the "best skill" based on the ratio of total profit to price (skill_profit / skill_price)

How ive fixed it in skills.py

[Alexell]

Okay, I finally understood what you meant. Sorry, I don't like math :D Yes, you are absolutely right, the ratio should be calculated as the ratio of the cost to the upcoming profit, and not to the total.