Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.55k stars 174 forks source link

macOS: Code-tree does not hide when you activate Project sidebar button #5265

Closed JairoMartinezA closed 1 year ago

JairoMartinezA commented 1 year ago

Alex,

I am using your last changes:

image

I change first to Code Tree tab and then I click to Project icon, but the info is not refreshing.

Alexey-T commented 1 year ago

I tried it on macOS El Capitan, Cud 1.195 x64, and it works ok. is it the regression of Cud 1.201? does Cud 1.195 work for you?

JairoMartinezA commented 1 year ago

Also, the Autocomplete frame doesn't disappear:

image

The bug is with the last changes of the CudaText sources, but let me try making a pull to Lazarus IDE, because when you ask me to create the ARM version, I proceeded with the update of Lazarus but only using FPCUpDeluxe.

Alexey-T commented 1 year ago

I confirm the bug with last Cud sources 1.201. i fear that some IDE regression may happen.

JairoMartinezA commented 1 year ago

I tested making the pull to Lazarus IDE sources and the result is the same.

Alexey-T commented 1 year ago

I want to test different versions of IDE (last, about month old, about 3 months old). it looks like IDE regression. If you can do it before me, it will be good.

@rich2014 , Hi. Did LCL have changes in showing/hiding/resizing of parented forms (on Cocoa)?

JairoMartinezA commented 1 year ago

IDE? Lazarus IDE or CudaText sources?

Alexey-T commented 1 year ago

Lazarus IDE.

Alexey-T commented 1 year ago

Jairo and @rich2014 I looked what branches exist at https://gitlab.com/freepascal.org/lazarus/lazarus and I tried 2 branches:

We have a Lazarus regression. @rich2014, I do not have the small demo yet. can you fix bug withjout small demo?

Alexey-T commented 1 year ago

I found how to reproduce it on small demo. https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40598

JairoMartinezA commented 1 year ago

Alex,

The last version that was working well was:

image

lazarus_3_0_RC1

davidbannon commented 1 year ago

git bisect tells me -

(removed totally wrong stuff because I did no do a clean build each time, see below, done properly)

Davo

EDIT : Hmm, Alexey's link now seems to point to a different bug report. My bisect refers to the test app he posted to https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/40598 - I am guessing this report, here refers to the same bug. If not, I apologize for the noise.

Alexey-T commented 1 year ago

The commit Docs: LCL/jsonpropstorage....... cannot affect LCL work on macOS, isn't it?

davidbannon commented 1 year ago

No, does not make sense. To be honest, I posted that bisect without manually checking it because some people were waiting for me. But testing again, now, no that is wrong.

I'll do the bisect again, this time I'll do a clean and trash the config each time, I only did that when moving backwards last time.

David

davidbannon commented 1 year ago

OK, very slow process with a full rebuild with each bisect. But the problem commit is

Oct 1st, 2023 Cocoa: Fix $40527: WindowState functions added to TCocoaWSCustomForm.ShowHide(), merge branch "cocoa/windowstate'. bb816b0e

Davo

rich2014 commented 1 year ago

@Alexey-T

fixed in Lazarus/Cocoa.

Alexey-T commented 1 year ago

@JairoMartinezA I confirm it's fixed. let's create the updated release, 2 files, please? with newer version number (after git pull).

JairoMartinezA commented 1 year ago

Hi Alex, @rich2014,

In my case, after running git pull and proceeding with make all in the Lazarus folder, I am encountering the following error:

Hint: (11030) Start of reading config file /etc/fpc.cfg
Hint: (11031) End of reading config file /etc/fpc.cfg
Free Pascal Compiler version 3.2.2 [2021/05/16] for x86_64
Copyright (c) 1993-2021 by Florian Klaempfl and others
(1002) Target OS: Darwin for x86_64
(3104) Compiling lazbuild.lpr
(10001) PPU Loading ../units/x86_64-darwin/nogui/idecmdline.ppu
(10011) PPU Source: idecmdline.pas not found
(10028) Recompiling IDECmdLine, checksum changed for /Users/aeromx/fpcupdeluxe/lazarus/components/lazutils/lib/x86_64-darwin/fileutil.ppu
/Users/aeromx/fpcupdeluxe/lazarus/ide/lazbuild.lpr(43,12) Fatal: (10022) Can't find unit IDECmdLine used by lazbuild
Fatal: (1018) Compilation aborted
make[2]: *** [lazbuild] Error 1
make[1]: *** [lazbuilder] Error 2
make: *** [lazbuild] Error 2

Do I need to update FPC or something?

Alexey-T commented 1 year ago

I usually run make (without all). this log line is strange:

(10001) PPU Loading ../units/x86_64-darwin/nogui/idecmdline.ppu

like you compile with NoGUI widgetset. but you want Cocoa widgetset. so try to delete folder units and call make.