search

Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.4k stars 167 forks source link

[Highlight Occurrences] Minor update in docs and opts #5428

Closed pintassilgo closed 3 months ago

pintassilgo commented 3 months ago
  1. You made visible_fallback enabled by default (thanks for that!), but it seems there are still some references of it being false. Look at readme.txt and at line 15 of opt.py.
  2. You changed find_hi_max_line_len from 4000 to 800000, but for HiOccur's max_line_len is still only 500, I'm sure Cuda can handle much more easily. I'm using 5000000 and at least a file with 812K length in a line can highlight matches instantly when I place the caret over a very common word (status message shows more than 8K matches!).
  3. Why is min_len = 2 by default instead of 1? I see no reason for that, and other editors like Sublime work with 1. I'm using 1 too and I believe it should be the default.
Alexey-T commented 3 months ago

applied all 3 suggestions. thanks for noticing.