search

Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.39k stars 166 forks source link

[Breadcrumbs] shouldn't use `EdTextBg` for background of the bar #5502

Closed pintassilgo closed 1 month ago

pintassilgo commented 1 month ago

I'm testing a theme in which only the editor is dark. Cuda chrome (window UI) still retains default theme.

But one thing feels wrong. While breadcrumbs are using Cuda chrome theme (light gray), the background of breadcrumbs bar is using the same background as the editor (dark in my theme). Look:

image

My suggestion: In breadcrumbs.py, replace

        cls.bg      = colors['EdTextBg     ]['color']

        cls.path_bg = colors['TabBg        ]['color']

by

        cls.bg      = colors['TabBg''     ]['color']

        cls.path_bg = colors['TabPassive''        ]['color']

Or something similar. Breadcrumbs bar should align its theme with tabs bar, but currently it's confusing, breadcrumbs follow tabs bar but the background of the bar follows editor background.

Result with my suggestion:

image

Much better, don't you think?

pintassilgo commented 1 month ago

Edit: moved to https://github.com/Alexey-T/CudaText/issues/5503.

Alexey-T commented 1 month ago

Pls move the 2nd post to a separate suggestion post.

1st post: I agree. will correct as suggested.

Alexey-T commented 1 month ago

Corrected as suggested (in 1st post).

pintassilgo commented 1 month ago

Thanks. Will you release an update for the plugin, right?

Edit: now I see, it was updated, thanks.