Closed pintassilgo closed 1 month ago
TextBg can be 'empty' by default to ratain old look. okay?
TextBg can be 'empty' by default to ratain old look. okay?
OK.
What color should Console/Output use?
Hmm... I think it can follow editor (so it would be dark for me).
Console input: follow editor. Codetree filter input: follow editor too?
Codetree filter input: follow editor too?
No, this one I think it's better to use the new property (supposing it doesn't have an exclusive one).
Done:
Thanks. Could you please upload a beta?
I don't intend to theme code tree because dark themes don't fit with dark icons such as the "𝑓" (function). Look:
So I'll need to keep it light, fixing the dark text input with the new property.
If it's doable, I suggest to investigate making light icons for dark themes (using your IsColorDark
or something similar to define if active theme is dark - or maybe the flag "darkTheme" should be set by the theme itself).
Beta uploaded
I suggest to investigate making light icons for dark themes
User can install different iconset for code-tree. from addons-manager.
It would be needed something similar to font color too, because font is reusing the one from editor.
By the way, how is the new item named in the "Color theme" dialog? EdTextBg
is editor, BG
, I suppose.
'single-line inputs text BG'.
needed something similar to font color too
OK.
I suggest to sort Color theme
dialog alphabetically. I know I can find by selecting one and start typing, but it should be sorted anyway.
Also, double-clicking an item should have the same effect as clicking "Config style" button.
I suggest to sort
Color theme
dialog alphabetically. I know I can find by selecting one and start typing, but it should be sorted anyway.
I like it more like now. it was arranged by hands.
Also, double-clicking an item should have the same effect as clicking "Config style" button.
Done. wait for the next beta.
I like it more like now. it was arranged by hands.
Because you're very used to it. Any random user expect the list to be sorted. Maybe with editor
-prefixed items at the top if you want, but the rest would be better sorted.
Beta updated.
Beta: added theme-item 'single line inputs, font'.
Thanks, confirmed OtherTextBg and OtherTextFont working as expected. Current beta (70) was uploaded before the dbclick commit, so I can't test this one.
Look...
Shouldn't this text input be white? My find input is white, command palette input is white. Why is this Breadcrumbs input dark?
Post this as a new issue - for plugin now. I will try to fix it (easy_) -- after the Cud release.
From what I see, any text field uses
EdTextBg
. I suggest to create a new property namedTextBg
for secondary text fields (typically single-line fields) like findbar and Command palette.EdTextBg
should be only for editor background. The new propertyTextBg
should fallback toEdTextBg
when unset, of course.Look:![image](https://github.com/Alexey-T/CudaText/assets/5483864/4131579f-56aa-4b85-a5a5-50f96fafc342)
I think it might look better if I can keep findbar field light, but from what I know it's impossible to change without affecting editor background.
The same applies to Command palette:![image](https://github.com/Alexey-T/CudaText/assets/5483864/176ae1cd-11ee-467c-bca8-45e0d69c38e5)