Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.39k stars 166 forks source link

Allow to customize other text fields instead of reusing editor properties #5503

Closed pintassilgo closed 1 month ago

pintassilgo commented 1 month ago

From what I see, any text field uses EdTextBg. I suggest to create a new property named TextBg for secondary text fields (typically single-line fields) like findbar and Command palette.

EdTextBg should be only for editor background. The new property TextBg should fallback to EdTextBg when unset, of course.

Look: image

I think it might look better if I can keep findbar field light, but from what I know it's impossible to change without affecting editor background.

The same applies to Command palette: image

Alexey-T commented 1 month ago

TextBg can be 'empty' by default to ratain old look. okay?

pintassilgo commented 1 month ago

TextBg can be 'empty' by default to ratain old look. okay?

OK.

What color should Console/Output use?

Hmm... I think it can follow editor (so it would be dark for me).

Alexey-T commented 1 month ago

Console input: follow editor. Codetree filter input: follow editor too?

pintassilgo commented 1 month ago

Codetree filter input: follow editor too?

No, this one I think it's better to use the new property (supposing it doesn't have an exclusive one).

Alexey-T commented 1 month ago

Done:

Screenshot from 2024-05-06 09-21-27

pintassilgo commented 1 month ago

Thanks. Could you please upload a beta?

pintassilgo commented 1 month ago

I don't intend to theme code tree because dark themes don't fit with dark icons such as the "𝑓" (function). Look: image

So I'll need to keep it light, fixing the dark text input with the new property. image

If it's doable, I suggest to investigate making light icons for dark themes (using your IsColorDark or something similar to define if active theme is dark - or maybe the flag "darkTheme" should be set by the theme itself).

Alexey-T commented 1 month ago

Beta uploaded

I suggest to investigate making light icons for dark themes

User can install different iconset for code-tree. from addons-manager.

pintassilgo commented 1 month ago

It would be needed something similar to font color too, because font is reusing the one from editor. image

By the way, how is the new item named in the "Color theme" dialog? EdTextBg is editor, BG, I suppose.

Alexey-T commented 1 month ago

'single-line inputs text BG'.

needed something similar to font color too

OK.

pintassilgo commented 1 month ago

I suggest to sort Color theme dialog alphabetically. I know I can find by selecting one and start typing, but it should be sorted anyway.

pintassilgo commented 1 month ago

Also, double-clicking an item should have the same effect as clicking "Config style" button.

Alexey-T commented 1 month ago

I suggest to sort Color theme dialog alphabetically. I know I can find by selecting one and start typing, but it should be sorted anyway.

I like it more like now. it was arranged by hands.

Alexey-T commented 1 month ago

Also, double-clicking an item should have the same effect as clicking "Config style" button.

Done. wait for the next beta.

pintassilgo commented 1 month ago

I like it more like now. it was arranged by hands.

Because you're very used to it. Any random user expect the list to be sorted. Maybe with editor-prefixed items at the top if you want, but the rest would be better sorted.

Alexey-T commented 1 month ago

Beta updated.

Alexey-T commented 1 month ago

Beta: added theme-item 'single line inputs, font'.

pintassilgo commented 1 month ago

Thanks, confirmed OtherTextBg and OtherTextFont working as expected. Current beta (70) was uploaded before the dbclick commit, so I can't test this one.

pintassilgo commented 1 month ago

Look... image

Shouldn't this text input be white? My find input is white, command palette input is white. Why is this Breadcrumbs input dark?

Alexey-T commented 1 month ago

Post this as a new issue - for plugin now. I will try to fix it (easy_) -- after the Cud release.

ildarkhasanshin commented 1 month ago

https://github.com/dimon40001/cudatext-theme-darcula/commit/26ce8ada67a42f27d7d0a53e3c4c0e00ea2f2183