search

Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.39k stars 166 forks source link

Lexer (None) specific settings influence other lexers on first paint #5519

Closed ThaiDat closed 1 month ago

ThaiDat commented 1 month ago

Regression: #5320

https://github.com/Alexey-T/CudaText/assets/18527312/3d445063-7bd2-4a56-ac9c-9cb2acba8cfd

Alexey-T commented 1 month ago

Can you describe in text, pls? I don't get the idea in video.

Steps to do on clean app? I made "wrap_mode":1 in "lexer -.json" and it is not applied to python files, if main user.json has "wrap_mode":0.

Alexey-T commented 1 month ago

But I see some effect. if in the FIRST EMPTY tab we reopen different files, file may get wrap=on (because of None lexer) and then it keeps this wrap=on after loading python file. I have the fix for it. tell me your About-window info, so I will give beta.

ThaiDat commented 1 month ago

My about window: 

CudaText
1.214.5.0
win-x86_64-win32, fpc 3.2.3

However, I am away from my desk. May test tomorrow

Alexey-T commented 1 month ago

Uploaded win64 beta to http://uvviewsoft.com/c/

EDIT I dont think this is a regression, the same must be visible on old versions.

ThaiDat commented 1 month ago

Tested. It is good now.

ThaiDat commented 1 month ago

An additional note that the fix made in this ticket also add the behavior desired in #5321

https://github.com/Alexey-T/CudaText/assets/18527312/a073f6bd-f984-4170-a05a-1b1a7040bad3

Alexey-T commented 1 month ago

Good.