Alexey-T / CudaText

Cross-platform text editor, written in Free Pascal
Mozilla Public License 2.0
2.53k stars 173 forks source link

Cuda shouldn't reserve space for `+` button (new tab) when it's hidden #5656

Closed pintassilgo closed 2 months ago

pintassilgo commented 2 months ago

I use this option:

"ui_tab_show_plus": false,

Yet, if scroll tab bar all to the right, it looks Cuda still reserves space for the + button. It shouldn't. There should be no space after last tab (in a window with many tabs, of course). image

Alexey-T commented 2 months ago

fixed, thanks.

pintassilgo commented 2 months ago

By the way, look how the scroll thumb doesn't touch the right edge of the window even when I can't scroll more. This annoys me a bit, doesn't look right. It would be good if thumb can touch the edges. If you say it's impossible, then the unreachable space should have different color so that user can see thumb is at the end of scrollable area.

Alexey-T commented 2 months ago

made it better: Screenshot_2024-08-18_10-21-27

(here it is at the very end of scrollable area, respecting last indent-right)

pintassilgo commented 2 months ago

Thanks, but what has changed? I don't understand. Thumb still doesn't touch the edge and also I can't see the limit of scrollable area.

pintassilgo commented 2 months ago

I was expecting something like one of these two solutions:

  1. Touch the edges. image

  2. User can see the limits of scrollable area. image

Alexey-T commented 2 months ago

okay, fixed more: Screenshot_2024-08-18_10-31-15

pintassilgo commented 2 months ago

Perfect, thank you.

pintassilgo commented 2 months ago

Still about this thumb/scroll thing.

If tab bar is scrollable to the left, you do Ctrl+Shift+Tab multiple times til you activate the first tab, then thumb touches left edge and you can't scroll left more: correct.

But this doesn't happen on the other side. Make Cuda scrollable to the right, then press Ctrl+Tab til you activate last tab. Thumb is not at the right edge and if you turn mousewheel over tabs Cuda will still scroll something like 3px to the right. This should be adjusted, it makes no sense to be able to scroll past the last tab, at least for those like me with no + button.

pintassilgo commented 2 months ago

Untitled14 is last tab, I was switching tabs from left to right using Ctrl+Tab. But look, thumb is not touching right edge... image

So I turned mouse scroll over tab... if you compare both images carefully, you'll see this one below scrolled 4px to the right. image

This is wrong. I activated last tab, making it fully visible, there should be no more scroll to the right after that. So thumb should be touching right edge on first pic and there should be no such gap right of the tab as in second pic.

Alexey-T commented 2 months ago

attempt to fix: cudatext.zip

pintassilgo commented 2 months ago

Looks fixed, thanks!

Alexey-T commented 2 months ago

fixed after our talk: