search

AlexeyDmitriev / JHelper

GNU Lesser General Public License v3.0
119 stars 31 forks source link

Update project to gradle #122

Closed rishabhdeepsingh closed 4 years ago

rishabhdeepsingh commented 4 years ago

I build the project directly as described on Jetbrains. AFAIK this should work perfectly as of now. Do u want me to revert all the changes?

AlexeyDmitriev commented 4 years ago

No, I'm not saying to revert all the changes. I'm just asking to move source(java) files and icons to original position src/main/java/name -> src/name src/main/resources/icons -> resources/name/admitriev/jhelper/icons/

To make it work in gradle, you'll need to add few lines of configuration in build.gradle (see the link for details)

rishabhdeepsingh commented 4 years ago

I have done as u said and now It is working perfectly without changing much of the code structure as before. Please review it again

AlexeyDmitriev commented 4 years ago

Thanks, it looks good now, I'll need to test that I still can run it locally and build the plugin for deployment. I hope to do that till the end of the weak.

rishabhdeepsingh commented 4 years ago

BTW This Gradle build downloads a fresh copy of the Clion and then we need a fresh project to import as well. I have tested it by myself and everything was perfect. You might need to add up more JVM Heap memory.

AlexeyDmitriev commented 4 years ago

Merged manually