search

AlexeySokolov / atom-smart-template

Template package for atom editor
MIT License
20 stars 5 forks source link

For directory templates, case is not preserved #5

Open sigurdsvela opened 8 years ago

sigurdsvela commented 8 years ago

The name of the directory is lowercase. So using "MyComponent" as the name becomes "my component/".

I'm using this tool to automatically create React components that are grouped with their stylesheet and any other resources in a directory. This is a fairly common approach, and one that needs the case to be preserved for the directory created.

christopherabouabdo commented 8 years ago

I found the conversion to lower case and removed it. It's obviously easy to do that in the code but there may have been philosophical reasons to converting directory names to lower case so I'm open to discussing those. @AlexeySokolov any thoughts on the subject?

@sigurdsvela The change didn't appear to break anything and I'm with you on the concept that React components should maintain their case in the directory name. Feel free to use my fork for the time being.

AlexeySokolov commented 8 years ago

I can't reproduce this bug. What kind of OS are you using? I recorded a small video for demonstration on OSX: https://youtu.be/2FEBdcK24Fg

Jeremboo commented 7 years ago

I have the same issue. Thank to the fork @christopherabouabdo. I also would like keeping uppercase on my directory name mainly for React template.

@AlexeySokolov this 'bug' applied only for the main directory name.

module.exports = {
    directory: true,
    ...
}

For example MyReactCompononent given : 

myreactcomponent/
   - MyReactComponent.js
   - ...
benvan commented 7 years ago

Just adding another voice here - I've literally just done exactly the same thing as @sigurdsvela re. react components. First off, thanks for a useful plugin Alex :)

I'm using @christopherabouabdo's fork for now (thanks Chris). @AlexeySokolov - can we merge his branch?

I can understand there being a compelling use case for a different directory name - perhaps we could offer a "directory" parameter instead?