search

AlexeySoshin / smali2java

Recreate Java code from Smali
486 stars 84 forks source link

Prevent panic if the input path does not exist. #13

Closed anders closed 4 years ago

anders commented 4 years ago

Fixes #5.

codecov-io commented 4 years ago

Codecov Report

Merging #13 into master will decrease coverage by 0.44%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage    75.1%   74.65%   -0.45%     
==========================================
  Files          20       20              
  Lines         498      501       +3     
==========================================
  Hits          374      374              
- Misses         97       99       +2     
- Partials       27       28       +1
Impacted Files Coverage Δ
smali2java.go 52.77% <0%> (-4.8%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c00e0d...9dffbbf. Read the comment docs.

AlexeySoshin commented 4 years ago

Thanks for the PR, but I'm not sure what's the usecase of continuing here?

anders commented 4 years ago

filepath.Walk stops processing when an error is returned from the walker function, so it will stop doing whatever it was doing.

$ ../smali2java -path_to_smali x
2020/02/06 23:04:01 Error occurred while walking path "x": lstat x: no such file or directory
$