Alexhuszagh / BreezeStyleSheets

Breeze/BreezeDark-like Qt StyleSheets
MIT License
548 stars 128 forks source link

Finished aliasing modifications & merged theme changes/ #111

Closed Inverted-E closed 1 month ago

Inverted-E commented 1 month ago

Ref #101

I had to modify configure.py as it would throw an exception when trying to build themes other than dark-blue and light-blue. The code for aliasing expected them to exist even if not requested. Now it'll only build the alias(es) if dark-blue and/or light-blue are in args.styles.

Changed -alt themes to

    "view:hover": "",

instead of

    "view:hover": "None",

This produces the same result.

Using "passthrough" or "transparent" does the opposite of what was desired, see screenshots below.

Using "none" or "" (desired effect):

none or

Using "transparent":

transparent

Using "passthrough":

passthrough

Alexhuszagh commented 1 month ago

Related to #101.

Alexhuszagh commented 1 month ago

By the way, I implemented #113 to deal with the increasing bundle sizes caused by #110 and due to an increasing number of variants of each style. This compresses the total size by >=90% and more themes will lead to a higher compression ratio, so there;s no real concerns ever adding more and more themes.

So if you have more good theme ideas, there's no real downside to adding them anymore, and thank you.

Inverted-E commented 1 month ago

113 is a good idea. I may add some new colors when I have some time. I also thought about adding a flag to disable the aliasing if not required in order to reduce file size but I guess that's less of a priority now. May still add it though if you think it's worth it?

Alexhuszagh commented 1 month ago

113 is a good idea. I may add some new colors when I have some time. I also thought about adding a flag to disable the aliasing if not required in order to reduce file size but I guess that's less of a priority now. May still add it though if you think it's worth it?

Much less so, also you can manually provide individual styles so you can choose a subset if required. Those will also compress very nicely so I can't imagine they'd affect file size more than a few bytes.