Alexia / php7mar

PHP 7 Migration Assistant Report (MAR)
GNU General Public License v3.0
797 stars 133 forks source link

Warning: Unterminated comment starting #44

Open trickeyone opened 5 years ago

trickeyone commented 5 years ago

I can't tell why this is being thrown, but whatever class was being processed apparently causied $tokens = token_get_all("<?php ".$matches[1]."?>"); to throw this warning.

Warning: Unterminated comment starting line 1 in /path/to/php7mar/classes/tests/critical.php on line 71

Call Stack:
    0.0011     383168   1. {main}() /path/to/php7mar/mar.php:0
    0.0012     383296   2. alexia\mar\main->__construct() /path/to/php7mar/mar.php:189
    0.9838    2562976   3. alexia\mar\main->run() /path/to/php7mar/mar.php:86
  810.4077    3245656   4. alexia\mar\tests->testLine() /path/to/php7mar/mar.php:139
  810.4077    3245656   5. call_user_func:{/path/to/php7mar/classes/tests.php:108}() /path/to/php7mar/classes/tests.php:108
  810.4077    3245656   6. alexia\mar\tests\critical->_duplicateFunctionParameter() /path/to/php7mar/classes/tests.php:108
  810.4077    3246328   7. token_get_all() /path/to/php7mar/classes/tests/critical.php:71

PHP: 5.6, 7.1 & 7.2 OS: Mac OS X High Sierra

trickeyone commented 5 years ago

And, apparently these warnings caused the report to not be written to the filesystem even though the "Report located at: " message displays.

petitchevalroux commented 5 years ago

+1 on php 5.5 and debian wheezy

Edit (adding sample code) : This kind of line seems to trigger that warning : public function setItems(/* array(Google_AdClient) */ $items)