search

AlexiaChen / mpvss-rs

The library implements a simple Publicly Verifiable Secret Sharing(PVSS) scheme in Rust.
Apache License 2.0
20 stars 3 forks source link

Issue with the license #4

Closed umgefahren closed 3 years ago

umgefahren commented 3 years ago

Hey! I really like what you did there and I'm considering building upon it. Although I'm probably unable tu make use of your library, because of the license you put it under. Unfortunately GPLv3 has a strong Copyleft which would mandate me to put my project under the same license. I want to be very clear: My project will be Open Source as well, but I want to make closed source adaptions possible (this is important for broad adoption). If you want to keep all changes here (although this is not legal council), you could consider changing to GPL with linking exception. I will, of course, respect all decisions regarding your choice of license, I just thought you might want to know. Best of wishes. Your work is amazing and there are only a few secret sharing libraries for Rust, so I really appreciate your work.

AlexiaChen commented 3 years ago

Hey @umgefahren !

Thank you for your appreciation, what can I do to help you? add GPL with linking exception ? How can I add this statement to my project? Also, if you find any problems or bugs using my library, feel free to fix the bugs or improve the performance of this library by pull request, because the performance of this library is not ideal at the moment, without using the underlying computing libraries like libgmp

charleschege commented 3 years ago

But it seems like there are no GPL licensed libraries in this repo? Where do you use libgmp?

charleschege commented 3 years ago

I would ask you to license this library in a more permissive license. This would be beneficial for the rust ecosystem. And your library is really well done, it could go a long way to improving our rust ecosystem for open source and commercial applications

AlexiaChen commented 3 years ago

@charleschege @umgefahren

OK. I can change it to MIT license if you want（now its GPLv3）. it does not use libgmp. feel free to contribute it by create PR

charleschege commented 3 years ago

MIT would be great

charleschege commented 3 years ago

MIT would be great

charleschege commented 3 years ago

https://github.com/AlexiaChen/mpvss-rs/pull/5 solves the license issue

charleschege commented 3 years ago

Is it possible to release a new version on crates.io with this license at this time?

AlexiaChen commented 3 years ago

@charleschege sure

AlexiaChen commented 3 years ago

@charleschege Github action failed: https://github.com/AlexiaChen/mpvss-rs/runs/3066841187

AlexiaChen commented 3 years ago

@charleschege published new version to crates.io, please check it

charleschege commented 3 years ago

Thanks