search

Alexpux / MSYS2-pacman

MSYS2 port of Arch Linux packman package manager.
GNU General Public License v2.0
164 stars 34 forks source link

`makepkg -e` runs `prepare()` #15

Closed elieux closed 9 years ago

elieux commented 9 years ago

Upstream pacman doesn't run prepare() when the -e argument is passed. MSYS2 pacman does.

I assume it's because of a this block: makepkg.sh.in#L2167-L2169

if (( PREPAREFUNC && !REPKG )); then
    run_prepare
fi

Why is it there?

Alexpux commented 9 years ago

This tell to not run prepare when you run repackage

elieux commented 9 years ago

Can you compare that section of makepkg.sh.in with upstream? It's not there at all.

DavidEGrayson commented 9 years ago

It looks like https://github.com/Alexpux/MSYS2-pacman/commit/8d1ee78f61b4953227841cedfab0c7a54c988ba5 fixes this.

elieux commented 9 years ago

Yeah, I talked to Alexey on IRC and he fixed it. Thanks, Alexey.