Closed kgaonkar6 closed 3 years ago
Rerun LGAT subtyping with hotspot+consensus maf
Just add hotspot maf pbta-snv-scavenged-hotspots.maf.tsv.gz from hotspot-detection to the snv calls used for subtyping.
pbta-snv-scavenged-hotspots.maf.tsv.gz
hotspot-detection
NA
I didn't expect any rna samples update I think the changes got in here : https://github.com/AlexsLemonade/OpenPBTA-analysis/commit/a73f44025eaf4cc07e562685e147f0e5ddacaba3#diff-bc6801a8061034d6b8f1ee90ed5771b19185f2f03276e0760cfa181f226da626 seems to have removed BS_J6VKB1VE ( 7316-974 ) from lgat samples but I don't see description why the sample was removed in that PR.
The sample has pathology_diagnosis == "Low-grade glioma/astrocytoma (WHO grade I/II)" so should be added to the lgat fusion sample list.
Yes
tables
2 sample have been updated because of adding hotspot mafs 7316-2575 and 7316-32
README
analyses/README.md
Thanks for the review! The fusion file shows that BS_J6VKB1VE was added in this PR because it seems to have been removed in a73f440.
BS_J6VKB1VE
Purpose/implementation Section
What scientific question is your analysis addressing?
Rerun LGAT subtyping with hotspot+consensus maf
What was your approach?
Just add hotspot maf
pbta-snv-scavenged-hotspots.maf.tsv.gz
fromhotspot-detection
to the snv calls used for subtyping.What GitHub issue does your pull request address?
959
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
I didn't expect any rna samples update I think the changes got in here : https://github.com/AlexsLemonade/OpenPBTA-analysis/commit/a73f44025eaf4cc07e562685e147f0e5ddacaba3#diff-bc6801a8061034d6b8f1ee90ed5771b19185f2f03276e0760cfa181f226da626 seems to have removed BS_J6VKB1VE ( 7316-974 ) from lgat samples but I don't see description why the sample was removed in that PR.
The sample has pathology_diagnosis == "Low-grade glioma/astrocytoma (WHO grade I/II)" so should be added to the lgat fusion sample list.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
2 sample have been updated because of adding hotspot mafs 7316-2575 and 7316-32
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.