Closed kgaonkar6 closed 3 years ago
@jharenza I’ve now updated the CN==0 as the only criteria for “deep loss”
The chromosome arm and cytoband level copy_number annotation uses only "gain" and "loss" as status; amplification is converted to gain Should we convert the "deep loss" added in this PR as "loss" for cytoband annotation OR do we want to add amplification and deep loss annotation to cytobands?
Does this sound ok as is ?
XY chromosomes don’t have a logic in the current code y to add applications does that sound ok too?
Thanks for the review @jharenza 🙌. I'll rerun and commit the updated nomenclature output
Purpose/implementation Section
What scientific question is your analysis addressing?
Add logic for a "deep loss" call for focal CN output files.
What was your approach?
Changed: https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/6bf301eea42a7f8812c3b14cee35a961097f8ecf/analyses/focal-cn-file-preparation/04-prepare-cn-file.R#L240-L247
To:
Changed: https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/6bf301eea42a7f8812c3b14cee35a961097f8ecf/analyses/focal-cn-file-preparation/04-prepare-cn-file.R#L265-L267
To:
What GitHub issue does your pull request address?
1099
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
NA
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
table
What is your summary of the results?
"Deep loss" calls were added to focal CN files for autosomes and X+Y calls.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.