Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
I will be updating the focal-cn-file-preparation and oncoprint with the updated consensus cnv as different PRs. Does that sound ok or should I add the updates in this PR since it's only reruns?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
Broad SVs calls from manta that don't have FILTER=='PASS' are removed.
The manta FILTER columns are distributed as :
Since looking at some deep deletion in chrX discrepancy lead to this investigation I'm pointing out the differences in deep deletions in consensus cnv in this PR compared to master
We see comparable calls in both versions of consensus cnv calls in all chromosome except chrX. Majority of the deep deletions in chrX are removed if we only filter for calls that PASS all filters in manta. Suggesting, that majority of the chrX deep deletions in the current master branch are low confidence calls.
Reproducibility Checklist
[x] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[x] This analysis has been added to continuous integration.
Documentation Checklist
[x] This analysis module has a README and it is up to date.
[x] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[x] The analytical code is documented and contains comments.
Thanks @jharenza for pointing that out! I have added some summary to specify why we investigated this and what the results suggest. Let me know if I should add more info.
Purpose/implementation Section
What scientific question is your analysis addressing?
Adding a FILTER==PASS for manta calls used in
copy_number_consensus_call
. I think this filter is necessary so that we use a subset of high-confidence broad SVs called by manta. https://github.com/Illumina/manta/blob/master/docs/userGuide/README.md#vcf-format-fieldsWhat was your approach?
Added
since 11th column is
FILTER
What GitHub issue does your pull request address?
1113
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
I will be updating the
focal-cn-file-preparation
andoncoprint
with the updated consensus cnv as different PRs. Does that sound ok or should I add the updates in this PR since it's only reruns?Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
Broad SVs calls from manta that don't have FILTER=='PASS' are removed. The manta FILTER columns are distributed as :
Since looking at some
deep deletion
inchrX
discrepancy lead to this investigation I'm pointing out the differences indeep deletions
in consensus cnv in this PR compared to masterWe see comparable calls in both versions of consensus cnv calls in all chromosome except chrX. Majority of the deep deletions in chrX are removed if we only filter for calls that
PASS
all filters in manta. Suggesting, that majority of the chrX deep deletions in the current master branch are low confidence calls.Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.