AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Updated analysis: oncoprint update aesthetics #1165

Closed jharenza closed 3 years ago

jharenza commented 3 years ago

What analysis module should be updated and why?

oncoprint-landscape

What changes need to be made? Please provide enough detail for another participant to make the update.

per comment here:

What input data should be used? Which data were used in the version being updated?

same as current

When do you expect the revised analysis will be completed?

next 1-2 weeks?

Who will complete the updated analysis?

@kgaonkar6 and/or @cbethell

cbethell commented 3 years ago

The following points from above have successfully been addressed in PR #1164:

jaclyn-taroni commented 3 years ago

Based on my read, only the last point about legends was relevant per https://github.com/AlexsLemonade/OpenPBTA-analysis/issues/1165#issuecomment-909384523 and the fact that the labels mentioned don't seem cutoff in the oncoprints in figures/pngs. I've filed #1178 with a series of steps to create the unified legend and final figure.