AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project

Other

99 stars 66 forks source link

#1144 part3 update telomerase activities figure #1168

Closed kgaonkar6 closed 3 years ago

kgaonkar6 commented 3 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Update Telomerase activity with cancer_groups.

What was your approach?

Updated code to only plot cancer_groups for main figure

What GitHub issue does your pull request address?

1144

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Do we want the Medulloblastoma or other molecular subtype plots in this figure?

Is there anything that you want to discuss further?

NA

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

figure

What is your summary of the results?

Reproducibility Checklist

[x] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[x] This analysis has been added to continuous integration.

Documentation Checklist

[x] This analysis module has a README and it is up to date.
[x] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[x] The analytical code is documented and contains comments.

jaclyn-taroni commented 3 years ago

I'm going to label this with don't merge until the NA gets removed.

kgaonkar6 commented 3 years ago

@jaclyn-taroni I've removed the NA now. Thanks for the review @jharenza @jaclyn-taroni !