AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Create minimal main display item palette (#1176) #1193

Closed jaclyn-taroni closed 2 years ago

jaclyn-taroni commented 3 years ago

Purpose/implementation Section

Addresses the new palette part of #1176. I haven't added documentation to the figures README yet. This is in part by design, because I plan on using this palette to remake figures for a bit to figure out if I've set this up in a way that makes sense. I'm also leaving the old palette in for now.

Key points:

jaclyn-taroni commented 3 years ago

Current version of the HTML file so folks can look at the palettes.

jaclyn-taroni commented 3 years ago

For additional context, this placeholder figure: https://github.com/AlexsLemonade/OpenPBTA-manuscript/blob/6be35a4ca8cd616b61bc24ccf6801f8e1f7054e7/content/images/main/Figure4.png

Would turn into (proof of concept)

fig4 proof of concept

Using this new palette strategy

jaclyn-taroni commented 2 years ago

Thanks for the review @jashapiro! I've added the other hex code to the displays by tacking that on with c() (otherwise you have to go about de-duplicating things later).

jaclyn-taroni commented 2 years ago

This doesn't currently get run in CI, so I'm going to merge without it.