Consider distinguishing `Progressive` and `Progressive Disease - Post Mortem` in tumor descriptor palette

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project

Other

99 stars 66 forks source link

Consider distinguishing `Progressive` and `Progressive Disease - Post Mortem` in tumor descriptor palette #1217

Closed jaclyn-taroni closed 2 years ago

jaclyn-taroni commented 2 years ago

In the palette used here, Progressive and Progressive Disease - Post Mortem have the same color. Is this intentional? Should they have different patterns, perhaps? Or should they be combined for the purposes of this plot? Seems odd to label them separately if there is no way to distinguish them in the plot itself.

_Originally posted by @jashapiro in https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/1201#discussion_r781268373_

sjspielman commented 2 years ago

One option for this could be to use different shades/tints (I am not the most well versed on which technical term is right here....) of the dark green currently used. Both currently use #075149. For example, we could do instead:

progressive: #38736d, a slightly lighter version of original
progressive post-mortem: #05403a, a slightly darker version of original

sjspielman commented 2 years ago

Closed with #1222