AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project

Other

100 stars 67 forks source link

Issue #1218: Add param to mapping-histology-labels.Rmd #1219

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Purpose/implementation Section

What was your approach?

Include an Rmarkdown param, with default of release-v21-20210820, to ensure flexibility of this notebook moving forward.

What GitHub issue does your pull request address?

1218

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Should the param be release-v21-20210820 or v21-20210820 with "release-" string added in?
I accidentally changed a ! to a ., but enthusiasm is maintained.

Is there anything that you want to discuss further?

Nope

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

N/A

Reproducibility Checklist

Documentation Checklist

[x] This analysis module has a README and it is up to date.
[x] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[x] The analytical code is documented and contains comments.

sjspielman commented 2 years ago

So, there's a lot of merges in my history here which I don't think is a problem, but there was mysteriously a draft file I made in 2019 that made it onto this branch which I just created today. I purged it, but it's in the history.

Can purge this whole history and do new PR without that weird file if preferred!