search

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 66 forks source link

Modified progressive / progressive disease post-mortem tumor descript… #1222

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Address Issue #1217 by tweaking hex code for tumor descriptors progressive and progressive post-mortem. Colors are now different shades (hues? tints? ....) of the same "dark teal".

What GitHub issue does your pull request address?

1217

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Agree with color choices?

Results

None

sjspielman commented 2 years ago

Ah just kidding, fully editing this comment - you mean the trailing FF? I had thought that was an opacity thing.

jaclyn-taroni commented 2 years ago

Yep, I mean the trailing FF. I don't know why it's there and #1161 (where it was added) does not explicitly say. My tired brain knew these were too long, but not that they were too long in the exact same way. That is to say that I expect them to be pretty easy to standardize, then.

sjspielman commented 2 years ago

OK, I vote merge this in first, and then I can open a separate issue/PR to track removing the FF opacity digits where appropriate?

jaclyn-taroni commented 2 years ago

I don't really see a reason to wait to make those updates, but okay.

sjspielman commented 2 years ago

I don't really see a reason to wait to make those updates, but okay.

Miscellaneous conflict avoidance, but I'll get everything in now.

EDIT: Aha, realizing it's only the tumor descriptor palettes that are funky. That's reasonably part of this PR.

jaclyn-taroni commented 2 years ago

I'm factoring in that it takes a bunch of time to run CI - so two minor PRs is double the waiting time!