AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 66 forks source link

Immune deconvolution updated heatmap #1232

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Purpose/implementation Section

From Issue #1230, this PR uses ComplexHeatmap to visualize immune deconvolution scores, with a matrix of cell types across samples (not groupings). The plot is therefore highly similar to that made for GSVA scores.

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Figure is here

Reproducibility Checklist

Documentation Checklist

sjspielman commented 2 years ago

Noting this failed because of CI time out.

Per discussions with @jaclyn-taroni, we may not want two heathap panels in figure 4. An alternative option that will still have the benefit of showing samples directly could be as follows -

sjspielman commented 2 years ago

To explore this other plotting option, I have added this figure which shows T cell CD8+ and overall immune scores for EPN and HGG cancer groups, with molecular subtypes highlighted.

This plot does not seem very informative to me, except potentially to look at overall immune scores that xCell estimates. Feedback or thoughts on how to move this approach forward (or not?) would be great!

jaclyn-taroni commented 2 years ago

I'd facet by cancer_group as well. But I think we should go about selecting what gets displayed a different way. My knee jerk reaction would be to subset to features with higher variance but it seems like we might expect scores to be on a different scale?

sjspielman commented 2 years ago

I did make a grand viz to get a sense of overall variability within cell types (attached and aptly titled). There are a handful of cell types without much variance, but most have quite a bit of variance across some, but not all, subtypes. The molecular subtypes are proving tricky to integrate here, especially since sample size across them varies so widely. This is just colored by cancer groups, to get an overall sense of the variance in cell type scores. woah.pdf

Woops, entered too soon. My idea was to use this figure to pull out cell types of interest, but I don't see many striking differences across the subtypes so choosing is tricky. It seems driven mostly by sample size.

jharenza commented 2 years ago

Hi @sjspielman! Coming back to this. Now that #1243 is merged, can you recreate the tmp and "woah" figures with those cell types + the XCell immune score?

Also, will you remove any subtypes which are "To be classified" and add MB subtypes to the EPN/HGG tmp figure? I can take a look at the patterning then and see if it makes sense with the literature.

Thanks!

sjspielman commented 2 years ago

Yes, but..I think we should actually shut down this PR though and start with a fresh one focusing on xCell etc. The original heatmap I made for this PR was headed in the wrong direction and a cleaner PR will be easier for review I think. I'll link back to this discussion in a new one!

Actually quick clarification - are you referring to the boxplot as "tmp" (is this "temporary")? I might be missing an acronym here :)

jharenza commented 2 years ago

Oh yes, I abbreviated temporary as tmp here! Sorry, was writing it fast, and sounds good re new PR!