Workflow panel for figure 1

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project

Other

99 stars 66 forks source link

Workflow panel for figure 1 #1244

Closed namansri468 closed 2 years ago

namansri468 commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

This pull request is for the manuscript issue https://github.com/AlexsLemonade/OpenPBTA-manuscript/issues/83 to include a panel in figure 1 showing the workflow process. The icons used are all CCBY.

Some places to look:

Is the overall workflow correctly represented?
Is there a different color scheme we might want to use?
Is anything critical missing from the figure?

sjspielman commented 2 years ago

Thanks for getting started on this @namansri468! Some immediate feedback I have here is about the process of code review. We want to emphasize that the joint approval of "authority reviews code" and "automatic testing in circle CI" leads to merging code and manubot contribution.

Maybe something like adding a vertical arrow in between (?) authority/automatic, and then an arrow coming out from there annotated "code approved" going into next steps, as in attached. OpenPBTA_Flowchart_D3.pdf

jharenza commented 2 years ago

Hi @sjspielman and @namansri468! Thanks for working on this. My one minor comment is that perhaps we should stay consistent with the repository and manuscript with text capitalization for "OpenPBTA" rather than "OPENPBTA". Thoughts?

sjspielman commented 2 years ago

Closing this PR after some in-house discussions about the direction for this figure. A new PR will be opened later.