Closed jaclyn-taroni closed 2 years ago
Thanks @jaclyn-taroni - can you print out either ependymoma or craniopharyngiomas? It looks like I did not separate out DMG within the all HGG oncoprint, but did for these other two.
I'm going to mark this ready for review now that I've updated the documentation. I am not going to add all the resultant tables until the code has been reviewed. We're using a maftools
function to do the summary, which is to say that I don't really expect (🤞🏻) any edge cases to pop up that wouldn't also pop up when we made the plots.
Purpose/implementation Section
We're reporting alterations per cancer group in https://github.com/AlexsLemonade/OpenPBTA-manuscript/pull/199, but we didn't yet have a tabular version of that data. What I'm adding here creates the equivalent tables
analyses/oncoprint-landscape/tables
for an individual cancer group.What was your approach?
Here I'm making the following changes:
analyses/oncoprint-landscape/00-prepare-goi-lists.R
where I create a table (analyses/oncoprint-landscape/data/cancer_group_goi_list_mapping.tsv
) that contains the mapping betweencancer_group
and what genes of interest (GOI) list to use. We only create the tables for _all samples in thebroad_histology
_ when a GOI list is used, so I mirrored that earlier design decision.analyses/oncoprint-landscape/04-alteration-counts-by-cancer-group.R
which does the following:analyses/oncoprint-landscape/tables/cancer_group_counts
where the subdirectory is determined by whether this is for primary only or primary plus (dictated by the shell script)analyses/oncoprint-landscape/03-oncoprint-n-count-table.R
to reduce redundant code for primary only vs. primary plus + removes the need to pass broad histology info to that scriptcancer_group
palette. If true, this doesn't matter. The pub-ready plots are made infigures/
.What GitHub issue does your pull request address?
1252
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes, but note that I am not adding all of the resulting tables yet.
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.