AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 66 forks source link

Count alterations represented in oncoprint on a per cancer group basis #1266

Closed jaclyn-taroni closed 2 years ago

jaclyn-taroni commented 2 years ago

Purpose/implementation Section

We're reporting alterations per cancer group in https://github.com/AlexsLemonade/OpenPBTA-manuscript/pull/199, but we didn't yet have a tabular version of that data. What I'm adding here creates the equivalent tables analyses/oncoprint-landscape/tables for an individual cancer group.

What was your approach?

Here I'm making the following changes:

What GitHub issue does your pull request address?

1252

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes, but note that I am not adding all of the resulting tables yet.

Reproducibility Checklist

Documentation Checklist

jharenza commented 2 years ago

Thanks @jaclyn-taroni - can you print out either ependymoma or craniopharyngiomas? It looks like I did not separate out DMG within the all HGG oncoprint, but did for these other two.

jaclyn-taroni commented 2 years ago

Yup, added EPN in https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/1266/commits/f714412a41b9edd248fbb37c48e5fa8d9a3217ea

jaclyn-taroni commented 2 years ago

I'm going to mark this ready for review now that I've updated the documentation. I am not going to add all the resultant tables until the code has been reviewed. We're using a maftools function to do the summary, which is to say that I don't really expect (🤞🏻) any edge cases to pop up that wouldn't also pop up when we made the plots.