AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Deprecate tmb-compare module #1298

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

This PR from Issue #1295 deprecates the tmb-compare module, which is very out of date. A figure in the manuscript is inspired by this module, but all associated code is in figures/scripts so this module does not need to be run.

Changes made include:

Question for reviewers: I left the analyses/README.md to still say "Yes" that this module is used in the MS, but with a parenthetical "(figure only)" added for context. Given that the figure is exclusively made in figures/scripts/, should this actually now say "No"?

jaclyn-taroni commented 2 years ago

Anything related to CI is being commented out. A previous failure was due to a timeout. If commenting things out were to cause an issue, it would likely be with the formatting of the YAML. If the YAML was screwed up in some way, I expect this would fail immediately, which is not the case.

Therefore, merging without CI!