Closed sjspielman closed 2 years ago
Correct, this should be primary only and we are not using primary-plus oncoprints for the manuscript. Can add an additional note to the S3 legend or text.
Changes do not affect CI. Merging before checks are complete.
This PR adds the compiled Figure S3:
figures/pngs/figureS3.png
figures/pdfs/supp/figs3/figureS3.pdf
Reviewers: Please confirm this is the right oncoprint plot. What is included here is
primary_only
, but there is also a figure panelfigures/pdfs/supp/figs3/panels/primary_plus_other_supplemental_oncoprint.pdf
forprimary_plus
. The slides version of this figure shows justprimary_only
, so that's what I compiled here. The current caption stub in the manuscript doesn't clearly spell out if this is meant to be primary only or plus -If the panel
figures/pdfs/supp/figs3/panels/primary_plus_other_supplemental_oncoprint.pdf
is indeed not going to be used, we should remove it and comment out associated aspects of its generating script.