AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Update oncoprint figures #1316

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Closes #1314 and #1315

Several updates were made to address some minor issues with the oncoprint landscape panels -

sjspielman commented 2 years ago

Converted to draft since something is wonky with 2 PDFs. Will revert back once this bug is addressed. Edit: ready to go!

sjspielman commented 2 years ago

@jharenza maftools sneakily, and without permission, replaces spaces with underscores in annotation label names internally. When I tried this approach (renaming columns) and it didn't work, I went digging through the package's source code and found that disappointing "feature."

sjspielman commented 2 years ago

These code changes do not affect CI, so we can merge before checks complete.