AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
99 stars 66 forks source link

Add cancer group plot to immune deconv notebook #1320

Closed jharenza closed 2 years ago

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Given that we are not highlighting any subtype-based immune cell type effects on survival, I think we should move the immune cell subtype plot to the supplement and create a cancer group plot as the main figure. This can go along with the GSVA immune scores, as I am discussing in the incoming PR for figure 5 updates in the manuscript repo.

Update - manuscript repo ticket draft here.

What was your approach?

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

I filtered cancer group > 15 to get the same subset as in mut sigs. I do slightly worry about two very similar plots, but they are showing completely different data, so I think we can go with it, unless you have any other ideas @sjspielman or @jaclyn-taroni ?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

new figures - updated subtype figure containing DMG and new cancer group figure

What is your summary of the results?

I am showing this by cancer group rather than immune cell type because I am talking about immune cells relative to others within a cancer group.

Reproducibility Checklist

Documentation Checklist

jaclyn-taroni commented 2 years ago

I'll review this!

jharenza commented 2 years ago

thanks @jaclyn-taroni - took the suggestions!