add two tabs to Table S1

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Taking tables out of methods and adding to Table S1

What was your approach?

tribbling

What GitHub issue does your pull request address?

https://github.com/AlexsLemonade/OpenPBTA-analysis/issues/1319

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

NA

Is there anything that you want to discuss further?

no

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

two tabs added

Reproducibility Checklist

[x] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[x] This analysis has been added to continuous integration.

Documentation Checklist

[x] This analysis module has a README and it is up to date.
[x] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[x] The analytical code is documented and contains comments.

jharenza commented 2 years ago

Something I'm not clear on is why some columns are documented as possible values of "text" but others are not. At first I thought it had to do with length of the possible values, but then I see for example ethnicity is text. I put a suggestion in for how populating the possible values can be done programmatically too.

Thanks, taking a look - this was created very long ago, so have to jog my memory and maybe other things make sense now.

jharenza commented 2 years ago

@sjspielman made the updates - just had a question as to whether we want to keep the programmatic option of all cancer groups there since it is quite long. I suppose people can wrap that column, so may be of interest.

sjspielman commented 2 years ago

just had a question as to whether we want to keep the programmatic option of all cancer groups there since it is quite long. I suppose people can wrap that column, so may be of interest.

I think it's fine to leave this long, since it's excel and people can definitely wrap it.

AlexsLemonade / OpenPBTA-analysis