jharenza
commented
2 years ago Looks good! One other quick thought - I think it's great that you added the reference level here into the plot. I wonder if we should change it's placement and/or color? Specifically, I think it makes sense for the reference to be the bottom row of the plot (though, still next to the other HGG levels). Also, the shape is white but it's not actually "not significant" - it's just not anything. What do you think about either making it gray, or maybe changing the shape to not be a diamond? Basically, some kind of visual cue that it's a different kind of point.
YES! I also had the thought about grey or another shape, and bottom is fine with me. I have multiple refs in other forest plots because of the groupings, but we can add those to the bottom or bottom of the group - what do you think?
sjspielman
Purpose/implementation Section
What scientific question is your analysis addressing?
Add HGG subtypes forest plot, staggered on #1332
What was your approach?
Add forest plot, including reference subtype
What GitHub issue does your pull request address?
Ahh, I guess I never made an issue for this..
Upate, found it #1323
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
NA
Is there anything that you want to discuss further?
From #1032
Since DMG H3 K28 is the reference, why isn't the p value for HGG, H3 wildtype significant in this additive model? It would actually be nice if we can show this significance value on the FP - maybe we can recode that one grey and add the pairwise pvalue? 😬
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.