Rerun EPN subtyping (2 of N) - Githubissues

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project

Other

100 stars 67 forks source link

Rerun EPN subtyping (2 of N) #1377

Closed jharenza closed 2 years ago

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

rerun EPN molecular subtyping

What was your approach?

What GitHub issue does your pull request address?

NA

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

no major changes - just decimals in the tables

Reproducibility Checklist

[ ] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[ ] This analysis has been added to continuous integration.

Documentation Checklist

[ ] This analysis module has a README and it is up to date.
[ ] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[ ] The analytical code is documented and contains comments.

jharenza commented 2 years ago

I'm approving this, but I made changes in 9c330c1 to use data/ files in release (this is more consistent with most subtyping modules FWIW, I looked) so @jharenza you should double-check that you agree!

looks good