The changes are expected based on changes seen in MB rerun and HGG rerun, though the HGG changes should not occur. Those are happening due to the samples not being in the classifier score output (#1383). We did not see expected LGG pathology free text cancer group/integrated dx being propagated.
This module had been grabbing a local copy of the collapsed stranded RNA-Seq file, which was 7 samples short - the same 7 HGG samples being removed from HGG subtyping. The ifelse looked ok to me, but I commented it out so the /data folder would be default and this brought back the 7 samples.
The "Notes" field from the base histologies file was being retained. Since it is all NA, during the join with compiled subtypes, samples were being removed, so I removed that field. I also made the update to convert the SEGA molecular subtype from "LGG, subtype" --> "SEGA, subtype".
rerun of mol sub integrate after code updates from #1387
Ran as a check, esp bc I noticed GNT recoding wasn't done til now. This new histologies file looks as expected given the updates in #1387, but we still also need to add the HGG and MB updates.
Code updates for #1376, #1383, and #1387 need to go in and then at least the following modules should be rerun:
molecular-subtyping-HGGmolecular-subtyping-pathologymolecular-subtyping-integrate
1383 logic needs to be checked - this was a quick and dirty way to do the update, so probably needs editing.
Code updates for #1376, #1383, and #1387 need to go in and then at least the following modules should be rerun:
molecular-subtyping-HGG
molecular-subtyping-pathology
molecular-subtyping-integrate
1383 logic needs to be checked - this was a quick and dirty way to do the update, so probably needs editing.
cc @jaclyn-taroni