AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Add Interaction sample calculation notebook #1398

Closed jharenza closed 2 years ago

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

The notebook added here records:

What was your approach?

Calculate the above from cooccur_top50.ALL.tsv and cooccur_top50.Diffuse-astrocytic-and-oligodendroglial-tumor.tsv

What GitHub issue does your pull request address?

This PR closes #1391

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

NA

Is there anything that you want to discuss further?

No

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

notebook with results

What is your summary of the results?

These numbers match those in the manuscript

Reproducibility Checklist

Documentation Checklist

jharenza commented 2 years ago

Yeah good point, will do. I was a little unsure how to add this since the dir structure is a bit different

jharenza commented 2 years ago

Yes, didn't see that one, thanks!

jharenza commented 2 years ago

@sjspielman ready for re-review. This was a very early module and so the readme doesn't explicity list every script and file as do others, so if we want to update, maybe @jashapiro can update that part. I updated more generally. In addition, I used a bash run script to be consistent with every other module.