AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

V22 run MB subtyping (3/N) #1435

Closed jharenza closed 2 years ago

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Run MB subtyping

What was your approach?

What GitHub issue does your pull request address?

1207 #1426

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

No change in subtypes, only clinical data

Reproducibility Checklist

Documentation Checklist

jaclyn-taroni commented 2 years ago

Are all the changes in analyses/molecular-subtyping-MB/input/subset-mb-clinical.tsv expected?

jharenza commented 2 years ago

Are all the changes in analyses/molecular-subtyping-MB/input/subset-mb-clinical.tsv expected?

It looks like these are because of column order changes. I didn't think that would have a major effect, but let me go back and match the order of the new base to previous so it is easier to detect changes. Also, parental_aliquot_id will no longer exist in base since it was removed from our database.

jharenza commented 2 years ago

@jaclyn-taroni looks a bit cleaner in 0e6f745. Expected changes due to base file.