AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

V22 sample distribution analysis rerun (14/N) #1447

Closed jharenza closed 2 years ago

jharenza commented 2 years ago

Purpose/implementation Section

What scientific question is your analysis addressing?

Rerun sample distribution analysis post v22 histology file generation

What was your approach?

Reran entire module. Added script 04 to the shell script, since it was missing.

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

I think these results look as expected - particularly, more LGG samples broken down by type of LGG. One question is, given https://github.com/AlexsLemonade/OpenPBTA-analysis/issues/1403, do we want to make this modification more upstream, as in #1446 for the cancer group? cc @sjspielman

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

Documentation Checklist

jharenza commented 2 years ago

I admittedly do not fully understand this question:

I think these results look as expected - particularly, more LGG samples broken down by type of LGG. One question is, given #1403, do we want to make this modification more upstream, as in #1446 for the cancer group?

But these updates look fine, and I expect we could update this module to use the palette if needed.

Yes, we discussed making this change to palette only