search

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

Update 1B and recompile Figure 1 #1520

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Closes #1517 and closes #1482

This PR updates Figure 1B to use correct abbreviations and re-compiles Figure 1. Additional code changes were included to re-size 1B for ease of compilation in 3rd party app. I also took this opportunity to update the figures/README.md file to indicate the Graphic for Mac app is used for compiling, not Illustrator. Internally, Illustrator is sometimes used for re-sizing individual panels, but the final compiled figures are all in Graphic format (extension .idraw). These files can be opened with Illustrator too!

jharenza commented 2 years ago

Oh, shoot - I think that "ET" also needs a rename to "Other ET" as well, in the palette. :(

sjspielman commented 2 years ago

Ah, my bad with ATRT, angled text behaves poorly in third party apps. Will fix that! I'll have a look at "Other ET" as well. If we have a separate issue for it I think it's fine to fix here.

sjspielman commented 2 years ago

This PR now also closes #1522.