search

AlexsLemonade / OpenPBTA-analysis

The analysis repository for the Open Pediatric Brain Tumor Atlas Project
Other
100 stars 67 forks source link

V22 compiled Figure S3 #1531

Closed sjspielman closed 2 years ago

sjspielman commented 2 years ago

Closes #1498 This PR re-compiles Figure S3 with V22 panels.

jharenza commented 2 years ago

Hi @sjspielman! Thanks for this update. Can you check out the compilation for panels C and D? It looks like there are extra shadows for these dots, which are not present in the original panels.

Screen Shot 2022-07-13 at 3 59 32 PM
sjspielman commented 2 years ago

@jharenza This may be because the points are transparent. Some features are challenging to retain in these apps. I may have to get rid of alpha and make the points smaller, but will try to get it right.

sjspielman commented 2 years ago

@jharenza This is now ready for another look. Turns out the code was missing useDingbats=FALSE, and added this into ggsave() fixed the points. I also ended up doing a bit of panel re-sizing to make compilation go a little quicker.

sjspielman commented 2 years ago

Code changes do not run through CI; merging before checks.