Closed jharenza closed 1 year ago
@jharenza the CI file-related updates should go into a different PR (analyses/create-subset-files/create_subset_files.sh
and analyses/create-subset-files/biospecimen_ids_for_subset.RDS
)
@jharenza the CI file-related updates should go into a different PR (
analyses/create-subset-files/create_subset_files.sh
andanalyses/create-subset-files/biospecimen_ids_for_subset.RDS
)
Oh let me remove those, I think that was leftover from my testing that script in a different branch
unzipped mafs are identical:
harenzaj@38f9d38f36c9 data % md5sum release-v22-20220505/*snv-consensus*maf.tsv
337cc86a1c62eb2cef3cc9d8669c2eda release-v22-20220505/pbta-snv-consensus-mutation.maf.tsv
f979aad447c9f8bcbac70b1fd2270a73 release-v22-20220505/tcga-snv-consensus-snv.maf.tsv
harenzaj@38f9d38f36c9 data % md5sum release-v23-20230115/*snv-consensus*maf.tsv
337cc86a1c62eb2cef3cc9d8669c2eda release-v23-20230115/pbta-snv-consensus-mutation.maf.tsv
f979aad447c9f8bcbac70b1fd2270a73 release-v23-20230115/tcga-snv-consensus-snv.maf.tsv
Purpose/implementation Section
What scientific question is your analysis addressing?
Prep for v23 release
What was your approach?
Run
generate-analysis-files.sh
for V23What GitHub issue does your pull request address?
NA
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Will look into the changes in files to see if something is strikingly wrong or maybe a change was missed previously. Update: these look ok, mainly due to updates in independent specimens and notebook HTML files. The
cnv_consensus.tsv
file has changed, but the final CNV files used in release do not change:I am going to investigate the SNV consensus maf changes, but my hunch is the row ordering is the cuplrit because I would also not expect those to change.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
yes
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Files being updated in release:
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.