What scientific question is your analysis addressing?
While the fusion summary file was updated to add YAP1--MAML2 (instead of YAP1--MAMLD2 in this previous PR, the module was not updated to handle this extra fusion. Here, I am adding that fusion to the list (curiously, YAP1--MAMLD2 was not previously in the list), and then adding it to the requirements list for YAP1 subtyping.
However, when I did this, the output file now has shifted columns and I am not well-versed in python to update this. just kidding, I think my rstudio rendering was smushed, this seems fine.
Note: this will not pass CI until we add the new files, since this fusion is missing from the summary file.
What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
[ ] The dependencies required to run the code in this pull request have been added to the project Dockerfile.
[ ] This analysis has been added to continuous integration.
Documentation Checklist
[ ] This analysis module has a README and it is up to date.
[ ] This analysis is recorded in the table in analyses/README.md and the entry is up to date.
[ ] The analytical code is documented and contains comments.
Purpose/implementation Section
What scientific question is your analysis addressing?
While the fusion summary file was updated to add
YAP1--MAML2(instead ofYAP1--MAMLD2in this previous PR, the module was not updated to handle this extra fusion. Here, I am adding that fusion to the list (curiously,YAP1--MAMLD2was not previously in the list), and then adding it to the requirements list for YAP1 subtyping.However, when I did this, the output file now has shifted columns and I am not well-versed in python to update this.just kidding, I think my rstudio rendering was smushed, this seems fine.Note: this will not pass CI until we add the new files, since this fusion is missing from the summary file.
What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.